Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use-preferred-write-partitioning for the Iceberg connector #8682

Closed
epogash opened this issue Jul 27, 2021 · 1 comment · Fixed by #9915
Closed

Support use-preferred-write-partitioning for the Iceberg connector #8682

epogash opened this issue Jul 27, 2021 · 1 comment · Fixed by #9915
Assignees

Comments

@epogash
Copy link

epogash commented Jul 27, 2021

When trying to utilize use-preferred-write-partitioning for Iceberg, there is no effect.

@findepi findepi mentioned this issue Jul 28, 2021
93 tasks
@findepi findepi self-assigned this Nov 2, 2021
@findepi
Copy link
Member

findepi commented Nov 4, 2021

#9834 adds repartitioning support for Iceberg.

per

Optional<PartitioningHandle> partitioningHandle = writeTableLayout.get().getPartitioning();
if (partitioningHandle.isPresent()) {
partitioningScheme = Optional.of(new PartitioningScheme(
Partitioning.create(partitioningHandle.get(), partitionFunctionArguments),
outputLayout));
}
else {
// empty connector partitioning handle means evenly partitioning on partitioning columns
preferredPartitioningScheme = Optional.of(new PartitioningScheme(
Partitioning.create(FIXED_HASH_DISTRIBUTION, partitionFunctionArguments),
outputLayout));
}

to fully leverage cost-based write partitioning selection, for identity-based partitions, we need not to return partitioning handle, and set only ConnectorNewTableLayout#partitionColumns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants