-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Support for jdbc catalog in Iceberg Connector #9968
Comments
+1 |
definitely! |
Hi - has this been abandoned? |
|
@ebyhr The point is that the REST catalog (like the HIVE catalog for that matter) requires deploying an additional component. which means maintaining another docker image, patching for CVEs and other compliance issues, making sure it is up etc. - all that for updating a couple of tables. So basically using REST is too much of an overhead with zero-value |
Thanks for that background @Arnonrgo. That is so far the biggest issue that we see with solely relying on the REST catalog over adopting multiple catalogs (JDBC, Nessie, etc..). To add more visibility into why we are even considering forgoing JDBC for now is where we focus our resources (maintainer and contributor review time). For instance, another issue people are bringing up is our lack of focus on the Trino Helm chart which we consider a priority. So every new feature we bring on has to be adopted with some scrutiny based on the larger needs of the community. We don't want to make this decision lightly as we understand that this becomes extra overhead for users, but it's a balancing act. I don't believe you are alone in having the concerns about overhead so please, if anyone else shares Arnon's opinion please give his comment a 👍🏻 so we can get a count rather than a bunch of +1 and "same" comments. Thank you all for understanding while we deliberate. I will be keeping you all in the loop on this. I'm also meeting with some folks from the Iceberg community today to see if we can get to the bottom of some technical concerns around JDBC in production that our maintainers have. Will fill you all in! Thank you for your patience! |
@almogtavor @jebnix @kingbrown9 @lynch19 I found you react with emoji to my above comment. Please be more verbal. We would like to hear use-cases from the community. Thumbs-down doesn't explain anything about it. |
@ebyhr I think there is no reason to give up on this great PR and work that have already been invested on this super anticipated feature (top 5 most liked and commented issues of Trino), just because of temporary time management issues. I don’t want to get involved with how the Trino developers time get managed, of course. But regarding the overhead of the REST Catalog I have to agree. That’s a pretty serious overhead to give to teams that just want to set up and maintain Trino for the Iceberg usage. The REST Catalog is much better than Hive metastore, but that’s still redundant overhead comparing to JDBC. A JDBC catalog is necessary because of the simplicity and support it has. The REST catalog is quite new, and I can see any situation where people would stop asking for the JDBC catalog, since it’s so ideal. From what it looks like, there is about of 80-90% of the work done. I don’t see any reason for it to get dropped. I agree that the Helm stuff is super important, but I’m not at the decision making position anyway. Will the JDBC get used? A lot. |
To update everyone here, based on @martint's comments here, we will be continuing to work on this feature to get it merged with the caveat that it will only be supported "as-is" with no guarantee from the Trino Software Foundation about future compatibility. cc: @jebnix, @Arnonrgo, @kingbrown9, @lynch19, @almogtavor, and others 😃 |
Would be great if trino supported jdbc catalog in iceberg connector
The text was updated successfully, but these errors were encountered: