Update BigQuery storage read API usage to v1 #10035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Nov 23, 2021
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadSessionCreator.java
Outdated
Show resolved
Hide resolved
The definitions are still valid, although they may no longer be required since some of this logic is now implemented directly in the client (see e.g. here). Would you like me to remove them, either as part of this PR or later? |
|
It should also be safe to remove e.g. BigQueryUtils.validColumnName, since the read API now supports BigQuery pseudo-columns. |
hashhar
reviewed
Nov 23, 2021
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadRowsHelper.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadSessionCreator.java
Show resolved
Hide resolved
emkornfield
reviewed
Nov 23, 2021
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestReadRowsHelper.java
Show resolved
Hide resolved
emkornfield
reviewed
Nov 23, 2021
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadSessionCreator.java
Show resolved
Hide resolved
ebyhr
approved these changes
Nov 24, 2021
Update BigQuery storage protos to v1 Update plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQuerySplitManager.java Co-authored-by: Yuya Ebihara <ebyhry@gmail.com> Update plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryPageSourceProvider.java Co-authored-by: Yuya Ebihara <ebyhry@gmail.com> Update plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadSessionCreator.java Co-authored-by: Yuya Ebihara <ebyhry@gmail.com> Fix code review feedback: rename member variable Revert unneeded pom.xml changes
kmjung
force-pushed
the
bigquery_storage_v1
branch
from
bb615bc to
33f2fff
Compare
hashhar
approved these changes
Nov 24, 2021
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestReadRowsHelper.java
Show resolved
Hide resolved
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Sep 14, 2022
Cherry-pick of trinodb/trino#10035 Co-authored-by: Kenneth Jung <kmjung@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the BigQuery connector to use the v1 interface for the BigQuery read API in preparation for the eventual turndown of v1beta1.