Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nested namespace support in REST catalog behind a config #24016

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Move nested namespace support in REST catalog behind a config #24016

merged 1 commit into from
Nov 7, 2024
+106 −12

Conversation

mayankvadariya
Copy link
Contributor

@mayankvadariya mayankvadariya commented Nov 4, 2024 •
edited by ebyhr
Loading

Description

Closes #23961

Release notes

## Iceberg
* Allow configuring whether reading nested namespaces. This is controlled by the new `iceberg.rest-catalog.nested-namespace-enabled` 
  catalog configuration property and defaults to `false`. ({issue}`24016`)

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@github-actions github-actions bot added docs iceberg Iceberg connector labels Nov 4, 2024
@mayankvadariya mayankvadariya marked this pull request as ready for review November 4, 2024 04:02
@mayankvadariya mayankvadariya force-pushed the mayank/nested-namespace-support branch 3 times, most recently from 01dc439 to eae7982 Compare November 4, 2024 22:54
@mayankvadariya mayankvadariya force-pushed the mayank/nested-namespace-support branch 2 times, most recently from 98001f5 to ed853db Compare November 6, 2024 01:23
@mayankvadariya
Copy link
Contributor Author

hitting https://github.com/trinodb/trino/actions/runs/11695464176/job/32570996731

@ebyhr ebyhr force-pushed the mayank/nested-namespace-support branch from f37a3b0 to e5ba1e8 Compare November 6, 2024 04:17
@mayankvadariya
Copy link
Contributor Author

@ebyhr apologies I forced pushed a change to fix one failure without realizing that there were changes from you. Please let me know if you want me to apply your changes.

@ebyhr
Copy link
Member

ebyhr commented Nov 6, 2024

@mayankvadariya I'm glad if you re-apply my changes.

@ebyhr ebyhr force-pushed the mayank/nested-namespace-support branch from 71cb58e to 640ecf2 Compare November 6, 2024 22:58
@ebyhr ebyhr merged commit ec2a985 into trinodb:master Nov 7, 2024
44 of 45 checks passed
@github-actions github-actions bot added this to the 465 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr Awaiting requested review from ebyhr

Assignees
No one assigned
Labels
cla-signed docs iceberg Iceberg connector
Milestone
465
Development

Successfully merging this pull request may close these issues.

Running SHOW SCHEMAS IN catalog makes N+1 requests to an iceberg REST catalog
2 participants
@mayankvadariya @ebyhr