-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Great War - two bugs in map #1331
Comments
The first of these issues requires clarification. I for one don't understand what is meant by the first issue. @Rogue77-NL Personally, I'd be inclined to close it shortly if the raiser doesn't do so. |
For the second issue (Songea - SZ 71 connection), I submitted a pull request in the map repository. For the first issue (Corsica territory problem), after investigation, I found that the game engine, when trying to get the territory that you hover, first tries to find a land territory else a water one. (MapData.getTerritoryAt() ) For great_war map, this is not true, as Water territories start with SZ, so it leads to problem when the Sea Zone is checked before the Land zone (as it is in the case of corsica). I do not know if this (start or end with Sea Zone) is supposed to be a requirement. All I could find is that in the TripleA Map Creator 1.0.1.4 release ( http://tripleadev.1671093.n2.nabble.com/TripleA-Map-Creator-1-0-1-4-Released-td4616118.html ) is mentioned:
So, if it is indeed a requirement, the great_war map should be updated. If it is not, the MapData.getTerritoryAt() should be updated to perform the check of weather the territory is water by some other means (probably get the territory by name, and then check isWater(), if territories are available there). In this case probably code should also be refactored so that Util.isTerritoryNameIndicatingWater is removed, in order to avoid similar problems in other places. I am willing to provide the fix, but since I am rather new here, I am not sure which one is the correct one. |
I guess the 1st issue doesn't need clarification after all, nor should the ticket be closed... ;) |
Cyprus is bugged, read made wrong too, as far as I know. Just it happens that there you have the territory you need superimposed, so the bug is not affecting the game. It is the same thing that me and @veqryn corrected in New World Order (Baleares and Krym). However this map was actually updated by @veqryn, so I'm actually curious if I'm overlooking anything (is or was there another legitimate way beside the Sea Zone naming or simply avoiding overlapping, at the price of having at least a line from the sea zone border to the island?) or maybe he had plans to update the engine to support it otherwise, meanwhile being content at the map working? |
you sure you're using the latest version? i fixed all seazone/island issues a while ago (like 1.5 years or something when i redid the map). maybe it was lost in the move to github? (or there is a regression in the map or the engine) |
@veqryn (it was more than 4 years ago) How did you fix them? What I and, I believe, everyone reading the available documentation knows is that, beside islands not being actual islands (that requires showing a line between the island and the sea zone border), the way to assure that is by the territory around the island ending in "Sea Zone". So, what was this other way you followed? Were there a (not documented?) rule of priority based on centers coordinates or anything like that? |
the polygons for the seazone exclude the island's polygon (ie: the line method) |
@veqryn I just tested the old releases since 1.6.1.4 and, from what I see, I believe you must be remembering wrong, or maybe you didn't get around updating to that point. While I see that 1.6.1.4 has still the old version 3.2, I see than in all engines from 1.7.0.3 till 1.8.0.9, all having the same new map version 4.3 installed, SZ 51 and SZ 65 are the same as now (the polygons for the sea zones include the islands' polygons). However, this conversation has gone far too long for something that can be easily corrected in a few minutes by rewriting the polygons for the sea zone to exclude the island's polygons, both for SZ 51 and SZ 65. Anyhow, the so called "line method" is really unpolished, thus I suggest a developer to add a map.properties option for defining all territories supposed to be possibly underneath others, defaulting to all territories ending in "Sea Zone" if not set, that should be something like: map.(...)_territory_names=SZ 51 Ligurian Sea,SZ 65 East Mediterranean Then update the map.properties of this map accordingly. If there are no developers that want to do something like this anytime soon, I guess I can pull what needed to address the problem the way @veqryn would do it, tho I don't like that solution. |
@Cernelius I'm not sure if I quite follow. Could you confirm if this is still an active problem, or if we still need to apply a fix to avoid the bug on this map? |
Hello! I have just updated from 1.9.0.0.3635 to 1.9.0.0.8304, and I'm now able to move land units to Corsica again, although the bottom left corner of the game window still shows 'SZ 51 Ligurian Sea' when you point the cursor at the island. However, land territory 'Songea' and sea zone 'SZ 71 Mozambique Channel' are still connected. I'm not quite sure what I'm looking at here..? triplea-maps/great_war@4d534f9. Will this issue be fixed eventually, or should it have been fixed already and am I missing something? Thanks again for your time! |
As I said:
|
I add the info that the reported connection bug has already been solved: |
Sounds like this is solved, is there anything further to be done? |
@DanVanAtta |
Hello, why has this issue been closed if according to @panther2 it is not completely solved yet? Kind regards. |
@Rogue77-NL See this discussion to learn about the "ice box - close and revisit later" label: |
...a bit late, but thanks again to all for your time and effort. I do like the map, and I appreciate it. :) |
@Rogue77-NL The issue has been fixed now. (triplea-maps/great_war#3) |
Hello,
The map Great War contains two bugs.
This was already the case in previous versions, judging by the territory name shown in the bottom left corner of the game window, but I was able to move land units to 'Corsica' nevertheless. Since the latest update of the game to version 1.9 the latter is not possible anymore. The infantry unit present at 'Corsica' at the beginning of a game can still be selected.
This bug was too minor for me to report separately, but the Corsica thing is influencing gameplay more significantly, so if I'm submitting a report anyway... :)
Thanks in advance for your time!
The text was updated successfully, but these errors were encountered: