Levy to Hill terrain attack/defence modifiers do not match documentation

[emmanuel-perlow]

According to the documentation a unit of type Levy should have -1 attack and +0 defence. However, in game a Levy has +0 attack and +1 defence.

I can find no indication which of these two (-1/0 or 0/1) is "the truth". If someone(TM) can figure that out/decide, I would be willing to provide a pull request fixing this.

Note: The terrain Pass has the same modifiers as Hill, so there might be an additional mismatch which needs fixing. The terrain Pass is undocumented see #7.

The territory modifications seem to be defined in the XML starting at line 4510 (the line with "spearman" is the Levy class)

battle_for_arda/map/games/Battle_For_Arda.xml

Lines 4534 to 4555 in e14d962

	<attachment name="territoryEffectAttachment" attachTo="hill" javaClass="games.strategy.triplea.attachments.TerritoryEffectAttachment" type="territoryEffect">
	<option name="combatOffenseEffect" value="raider:variag_raider:rohirric_scout:elven_cavalry:easterling_cavalry:eotheod_cavalry:eorling_rider:dunadan_lancer:chariot:wainrider_chieftain:swan_knight:kings_company:oliphaunt:oliphaunt_hit2" count="-1" />
	<option name="combatDefenseEffect" value="raider:variag_raider:rohirric_scout:elven_cavalry:easterling_cavalry:eotheod_cavalry:eorling_rider:dunadan_lancer:chariot:wainrider_chieftain:swan_knight:kings_company:oliphaunt:oliphaunt_hit2" count="0" />
	<option name="combatOffenseEffect" value="dunlending_wildman:beorning_warrior:snaga_skirmisher:scout:warg_scout:warg_rider:troll:olog_hai:bear" count="1" />
	<option name="combatDefenseEffect" value="dunlending_wildman:beorning_warrior:snaga_skirmisher:scout:warg_scout:warg_rider:troll:olog_hai:bear" count="1" />
	<option name="combatOffenseEffect" value="barrow_wight:goblin_shooter:woodman:ranger:elven_hunter:spider" count="0" />
	<option name="combatDefenseEffect" value="barrow_wight:goblin_shooter:woodman:ranger:elven_hunter:spider" count="2" />
	<option name="combatOffenseEffect" value="uruk_pikeman:dunadan_guard:barding_infantry:black_numenorean:tower_guard:dwarven_halberdier:wizard" count="0" />
	<option name="combatDefenseEffect" value="uruk_pikeman:dunadan_guard:barding_infantry:black_numenorean:tower_guard:dwarven_halberdier:wizard" count="1" />
	<option name="combatOffenseEffect" value="orc_marauder:uruk_warrior:helming_warrior:balchoth_tribesman:oathbreaker:trollman:nazgul:winged_nazgul:balrog" count="0" />
	<option name="combatDefenseEffect" value="orc_marauder:uruk_warrior:helming_warrior:balchoth_tribesman:oathbreaker:trollman:nazgul:winged_nazgul:balrog" count="0" />
	<option name="combatOffenseEffect" value="elven_warden:noldorin_warrior:galadhrim_longbowman:elven_archer:huorn:ent" count="-1" />
	<option name="combatDefenseEffect" value="elven_warden:noldorin_warrior:galadhrim_longbowman:elven_archer:huorn:ent" count="0" />
	<option name="combatOffenseEffect" value="dwarven_axeman:dwarven_pikeman:dwarven_axethrower" count="1" />
	<option name="combatDefenseEffect" value="dwarven_axeman:dwarven_pikeman:dwarven_axethrower" count="2" />
	<option name="combatOffenseEffect" value="spearman:halforc:goblin_stabber:riddermark_militia:man_at_arms:corsair:hobbit_archer:bowman:pony_rider" count="0" />
	<option name="combatDefenseEffect" value="spearman:halforc:goblin_stabber:riddermark_militia:man_at_arms:corsair:hobbit_archer:bowman:pony_rider" count="1" />
	<option name="combatOffenseEffect" value="eagle:crebain:raven:bat:dragon:dragon_hit2" count="1" />
	<option name="combatDefenseEffect" value="eagle:crebain:raven:bat:dragon:dragon_hit2" count="1" />
	<option name="combatOffenseEffect" value="war_wagon:ancient_tower:fortress:ancient_wall:wall" count="0" />
	<option name="combatDefenseEffect" value="war_wagon:ancient_tower:fortress:ancient_wall:wall" count="3" />
	</attachment>