Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multibyte chars in text lines #48

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: multibyte chars in text lines #48

merged 2 commits into from
May 31, 2024

Conversation

tris203
Copy link
Owner

@tris203 tris203 commented May 31, 2024

Closes #47

This has made some problems with b more obvious, I will take a look at these later

willothy
willothy approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@willothy willothy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Nitpick is nbd :)

I'll test it out on my machine later

lua/precognition/init.lua Outdated Show resolved Hide resolved
@tris203
Copy link
Owner Author

tris203 commented May 31, 2024

I think this now fully supports multibyte chars, please have another quick look and test please @willothy
and then you can merge this if you approve!

@tris203 tris203 requested a review from willothy May 31, 2024 22:10
@josh-nz
Copy link
Contributor

josh-nz commented May 31, 2024

My testing of the readme header looks good. Thanks for the fix.

willothy
willothy requested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@willothy willothy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Works for me! Noticed a couple of issues with the w motion, but they're unrelated to this PR. Will document/repro later. Nice work!

Edit: Meant to approve

@willothy willothy merged commit f893367 into main May 31, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request May 26, 2024
Merged
@tris203 tris203 deleted the extended_chars branch June 3, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willothy willothy willothy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multibyte Characters in text
3 participants
@tris203 @josh-nz @willothy