Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax protobuf requirements for tritonclient #434

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Relax protobuf requirements for tritonclient #434

merged 1 commit into from
Nov 16, 2023

Conversation

jbkyang-nvi
Copy link
Contributor

No description provided.

@debermudez
Copy link
Contributor

breaking protobuf 4.21.0 changes
have those been addressed?
Can you link in a comment for traceability?

@jbkyang-nvi
Copy link
Contributor Author

jbkyang-nvi commented Nov 14, 2023 •
edited
Loading

breaking protobuf 4.21.0 changes
have those been addressed?
Can you link in a comment for traceability?

It seems like the linked ticket is closed: protocolbuffers/protobuf#10051
Running tests to make sure it doesn't break things.

debermudez
debermudez approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@debermudez debermudez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming testing passes, this is good to go. Thanks for linking the ticket in a comment.

@jbkyang-nvi jbkyang-nvi merged commit 4cac971 into main Nov 16, 2023
3 checks passed
@jbkyang-nvi jbkyang-nvi deleted the kyang-update-protobuf branch November 16, 2023 03:02
@jbkyang-nvi
Copy link
Contributor Author

closes
#4984: version 3 incompatible with many other libraries
#4988 Triton image_client.py fails to run
#6095 tritonclient protobuf version

@ozen
Copy link

ozen commented Nov 21, 2023

I hope this gets into the 23.11 release.

@jbkyang-nvi
Copy link
Contributor Author

I hope this gets into the 23.11 release.

Hi @ozen it will be 23.12 release. You can build it yourself from main if you want it sooner

@ozen
Copy link

ozen commented Nov 22, 2023

@jbkyang-nvi Got it, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debermudez debermudez debermudez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbkyang-nvi @debermudez @ozen