-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taal: AMR callback should "notify" "all" parts of the code when the mesh has changed #215
Comments
What about introducing appropriate methods of |
Which |
No, something like |
Hm, so without any arguments for a new size, just as an "something has changed" indicator? In that case, what about using something more descriptive such as |
I'm sorry, I forgot the |
I think now that you are already optimizing the dt calculation on have_constant_speed, we should probably skip calculating dt in each time step for those cases and only calculate it once after each mesh adaptation and store it in some cache.
Originally posted by @sloede in #200 (comment)
That's a good suggestion but requires additional logic. For example, the AMR callback and the stepsize callback need to know each other to do that. As you may have seen in other TODO notes, I was thinking about letting the AMR callback notify everything when something has been adapted. If we implement that, we can also add this optimization. Could you please open an issue for that?
Originally posted by @ranocha in #200 (comment)
The text was updated successfully, but these errors were encountered: