Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sincospi when moving to Julia v1.6 #277

Closed
ranocha opened this issue Nov 2, 2020 · 0 comments
Closed

Use sincospi when moving to Julia v1.6 #277

ranocha opened this issue Nov 2, 2020 · 0 comments
Labels
good first issue Good for newcomers performance We are greedy

Comments

@ranocha
Copy link
Member

ranocha commented Nov 2, 2020 •
edited
Loading

Xref JuliaLang/julia#35816

However, we should probably decide whether we favor accuracy (i.e. sincos(x)) or speed (i.e. sincos(pi * x)) in general, also for sinpi and cospi.
@ranocha ranocha added the performance We are greedy label Nov 2, 2020
@ranocha ranocha mentioned this issue Nov 2, 2020
Merged
@ranocha ranocha added the good first issue Good for newcomers label Nov 12, 2020
@ranocha ranocha closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers performance We are greedy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranocha