Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative tolerance to check convergence for HypDiff #98

Closed
ranocha opened this issue Aug 18, 2020 · 2 comments · Fixed by #200
Closed

Use relative tolerance to check convergence for HypDiff #98

ranocha opened this issue Aug 18, 2020 · 2 comments · Fixed by #200
Labels
enhancement New feature or request

Comments

@ranocha
Copy link
Member

ranocha commented Aug 18, 2020

In GitLab by @andrewwinters5000 on Jun 24, 2020, 07:27

This came up last week in a Slack discussion. We should try out using relative tolerance to kill the steady-state computation. Right now the residual check is just an absolute tolerance.
@ranocha ranocha added enhancement New feature or request to do labels Aug 18, 2020
@ranocha
Copy link
Member Author

ranocha commented Aug 21, 2020

Do we still want to have this, @andrewwinters5000? Otherwise, feel free to close this issue.

@andrewwinters5000
Copy link
Member

No for the tests in the paper the relative tolerance does not really change anything. I will close this issue

@ranocha ranocha mentioned this issue Oct 14, 2020
Merged
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge Taal into master trixi-framework/Trixi.jl
2 participants
@ranocha @andrewwinters5000