Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize save_solution_file for AbstractCovariantEquations to support solution_variables which depend on auxiliary variables #51

Merged
merged 7 commits into from
Nov 30, 2024

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Nov 26, 2024

This PR specializes Trixi.save_solution_file for the covariant form to allow for variable conversions that depend on auxiliary variables, and may return a different number of variables than nvariables(equations). Specifically, equations of type AbstractCovariantEquations should use solution_variables(u, aux_vars, equations) instead of solution_variables(u, equations). A default cons2cons(u, aux_vars, equations) = u option has been defined.

@tristanmontoya tristanmontoya changed the title Specialize save_solution_file for AbstractCovariantEquations to support solution_variables conversion that depends on auxiliary variables WIP: Specialize save_solution_file for AbstractCovariantEquations to support solution_variables which depend on auxiliary variables Nov 26, 2024
@tristanmontoya tristanmontoya marked this pull request as ready for review November 26, 2024 18:09
@tristanmontoya tristanmontoya changed the title WIP: Specialize save_solution_file for AbstractCovariantEquations to support solution_variables which depend on auxiliary variables Specialize save_solution_file for AbstractCovariantEquations to support solution_variables which depend on auxiliary variables Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.56%. Comparing base (40800a6) to head (d2dba0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/callbacks_step/save_solution_covariant.jl 95.00% 1 Missing ⚠️
src/equations/equations.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   87.49%   87.56%   +0.06%     
==========================================
  Files          17       18       +1     
  Lines        1423     1447      +24     
==========================================
+ Hits         1245     1267      +22     
- Misses        178      180       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated Show resolved Hide resolved
src/callbacks_step/save_solution_covariant.jl Outdated Show resolved Hide resolved
src/callbacks_step/save_solution_covariant.jl Outdated Show resolved Hide resolved
@tristanmontoya tristanmontoya merged commit 8ce924e into main Nov 30, 2024
10 checks passed
@tristanmontoya tristanmontoya deleted the tm/covariant_save_solution branch November 30, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants