WIP: Icosahedral grid with multiple trees per quad face of icosahedron #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arr/icosahedral_grid #52 +/- ##
========================================================
+ Coverage 89.20% 89.82% +0.61%
========================================================
Files 18 18
Lines 1631 1729 +98
========================================================
+ Hits 1455 1553 +98
Misses 176 176 ☔ View full report in Codecov by Sentry. |
amrueda
added a commit
that referenced
this pull request
Dec 2, 2024
* First implementation of an icosahedral grid with 3 quads on each triangular face * Removed cells_per_dimension from elixir * Changed radius in initial_condition_gaussian * Added test for spherical advection on icosahedral grid * Improved ascii art? * Added information to run convergence test with P4estMeshCubedSphere2D * Corrected advection elixir for tests * Fixed initial condition to avoid pole singularities * WIP: Icosahedral grid with multiple trees per quad face of icosahedron (#52) * Added the possibility to have multiple trees per quad face of icosahedron * Updated advection elixir (and test) that uses the quad-based icosahedral grid * Updated spherical advection reference solutions to account for changes in the initial condition * Improve comments * Remove sqrt in initial condition to make it slightly cheaper * Fix comment * Redefined index maps as constant tuples and improved the comments * typo * Moved all export statements to TrixiAtmo.jl and fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.