Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paper] Fix formatting of citations #616

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

giordano
Copy link
Contributor

Note: I haven't tried to build the paper myself, but according to JOSS formatting instructions and Pandoc documentation, for citations where the paper is referred to in the text (rather than being mentioned in a parenthetical list) you should remove the square brackets. Also, according again to Pandon documentation for multiple citations together one should use the style [@ref1; @ref2] instead of [@ref1], [@ref2].

@svchb svchb requested a review from LasNikas September 22, 2024 18:14
@LasNikas
Copy link
Collaborator

Thanks a lot! I tried to build the paper and it works.
The only thing was to update the upload-artifact action (see https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/)

@LasNikas LasNikas merged commit 8ecf5e6 into trixi-framework:paper-2024-joss Sep 24, 2024
@giordano giordano deleted the patch-1 branch September 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants