Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage #674

Merged
merged 11 commits into from
Dec 11, 2024
Merged

Improve Test Coverage #674

merged 11 commits into from
Dec 11, 2024

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Nov 21, 2024

No description provided.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (c93ab39) to head (4464531).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...chemes/boundary/dummy_particles/dummy_particles.jl 96.42% 2 Missing ⚠️
test/callbacks/postprocess.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   68.39%   68.51%   +0.12%     
==========================================
  Files          87       87              
  Lines        5401     5406       +5     
==========================================
+ Hits         3694     3704      +10     
+ Misses       1707     1702       -5     
Flag Coverage Δ
unit 68.51% <94.73%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb self-assigned this Nov 22, 2024
svchb and others added 4 commits December 2, 2024 12:10
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
@svchb svchb requested a review from efaulhaber December 2, 2024 11:11
efaulhaber
efaulhaber previously approved these changes Dec 2, 2024
@efaulhaber
Copy link
Member

@LasNikas do you want to take a look as well before this is merged?

@LasNikas
Copy link
Collaborator

LasNikas commented Dec 2, 2024

yes please

@svchb
Copy link
Collaborator Author

svchb commented Dec 10, 2024

@LasNikas Reminder! This waits for over a week now.

@LasNikas LasNikas merged commit f051b55 into trixi-framework:main Dec 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants