Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reek does not handle relative paths from config file #1283

Open
dansdantas opened this issue Dec 20, 2017 · 0 comments
Open

Reek does not handle relative paths from config file #1283

dansdantas opened this issue Dec 20, 2017 · 0 comments
Labels

Comments

@dansdantas
Copy link
Contributor

As stated on #1243 , using reek at child level for configurations on ancestors directories does not handle a relative path.

Eg: .reek

"config/":
  IrresponsibleModule:
    enabled: false

reek config/application.rb

 example (master) ✗ reek config/application.rb
 Inspecting 1 file(s):
 .

Child directory - reek application.rb

 config (master) ✗ reek application.rb
 Inspecting 1 file(s):
 S

 application.rb -- 1 warning:
[10]:IrresponsibleModule: Example::Application has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
@mvz mvz added the defect label Dec 20, 2017
@mvz mvz added this to the Reek 4.8 milestone Jan 5, 2018
@mvz mvz removed this from the Reek 4.8 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants