You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
however, after adding a comment at the end of the method, the suppression seems to no longer work and reek reports the LongParameterList smell:
classExampleClass# :reek:LongParameterListprivatedefsome_method(first,second,third,fourth,fifth)p1# content of this comment doesn't seem to matterendend
interestingly, removing the class seems to also cause the issue to stop (the smell is suppressed) despite the comment remaining:
# :reek:LongParameterListprivatedefsome_method(first,second,third,fourth,fifth)p1# content of this comment doesn't seem to matterend
also it appears that adding another method before some_method causes the suppression to break again:
deffooend# :reek:LongParameterListprivatedefsome_method(first,second,third,fourth,fifth)p1# content of this comment doesn't seem to matterend
Reproduction
To reproduce, set up files one.rb, two.rb, three.rb, four.rb with contents of the above four snippets. Then this is the output from reek, along with related ruby/gem versions:
Reek (6.1.4) does not report any smells for the following code:
however, after adding a comment at the end of the method, the suppression seems to no longer work and reek reports the LongParameterList smell:
interestingly, removing the class seems to also cause the issue to stop (the smell is suppressed) despite the comment remaining:
also it appears that adding another method before
some_method
causes the suppression to break again:Reproduction
To reproduce, set up files one.rb, two.rb, three.rb, four.rb with contents of the above four snippets. Then this is the output from reek, along with related ruby/gem versions:
The text was updated successfully, but these errors were encountered: