fsck output string truncation too short

[hongkongkiwi]

I noticed that my startup logs look like this:

[ OK ] Checking filesystem /dev/mmcblk0p
[ OK ] Checking filesystem /dev/mmcblk0p
[ OK ] Checking filesystem /dev/mmcblk0p
[ OK ] Checking filesystem /dev/mmcblk0p
[ OK ] Checking filesystem /dev/mmcblk0p

After investigation I found that there is a hardcoded size for an output string here:

finit/src/finit.c

Line 259 in 181d955

fsck_rc = run_interactive(cmd, "Checking filesystem %.13s", dev);

So this assumes that the string is not more than 13 chars, however I think this is not necessarily true. e.g.

• /dev/mmcblk0p1 is 15 chars
• /dev/mmcblk0p14 is 16 chars
• Some people are using: /dev/mmcblk0boot0 which is 18 chars....

So my suggestion is to set this to by default 18 chars as that should cover a majority of cases.

Additionally, if it's larger than 18 chars, for example if you had a weird case of "/dev/mmcblk0boot10" perhaps you could append ... e.g. [ OK ] Checking filesystem /dev/mmcblk0boot1... so people know it's been truncated.

Or perhaps no need to set any limit on the size?

[troglobit]

Yes, thanks for pointing this out!