Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the RpcClient cleanup thread from cleaning up the client object that is about to be used #76

Closed
wants to merge 1 commit into from

Conversation

eric-zc1
Copy link
Contributor

  1. RpcClient超时时间日志问题修复
  2. RpcClientProxy的lastUsedNanos使volatile,避免多线程可见性不一致;
  3. 使用ConcurrentMap的compute,在返回之前updateLastUsedNanos,保证其他线程get的时候拿到的是都是已经更新过最后使用时间的

2. RpcClientProxy的lastUsedNanos使volatile,避免多线程可见性不一致;
3. 使用ConcurrentMap的compute,在返回之前updateLastUsedNanos,保证其他线程get的时候拿到的是都是已经更新过最后使用时间的
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


ericzcwang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.09821%. Comparing base (d5ad43f) to head (5d1f16c).

Files with missing lines Patch % Lines
...ent/trpc/core/cluster/RpcClusterClientManager.java 85.71429% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##                master         #76         +/-   ##
=====================================================
- Coverage     70.13739%   70.09821%   -0.03919%     
+ Complexity        4240        4235          -5     
=====================================================
  Files              437         437                 
  Lines            17105       17106          +1     
  Branches          1727        1727                 
=====================================================
- Hits             11997       11991          -6     
- Misses            3992        3997          +5     
- Partials          1116        1118          +2     
Files with missing lines Coverage Δ
...ent/trpc/core/cluster/RpcClusterClientManager.java 52.84553% <85.71429%> (-0.43317%) ⬇️

... and 4 files with indirect coverage changes

@eric-zc1
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@eric-zc1 eric-zc1 closed this Jan 14, 2025
@eric-zc1 eric-zc1 deleted the 132-issue branch January 14, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant