Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visited link fails #98

Open
mrx23dot opened this issue May 22, 2022 · 5 comments
Open

Visited link fails #98

mrx23dot opened this issue May 22, 2022 · 5 comments

Comments

@mrx23dot
Copy link

It fails to remember that I clicked this url:
<a href="intent:http://192.168.0.1:8200/MediaItems/52.mkv#Precious%202009#Intent;package=com.mxtech.videoplayer.pro;S.title=Precious%202009;end"> Precious </a>

It shows unvisited color every time.
This is a link that opens DLNA stream directly in MXplayer, standard Chrome intent link.

Visited state works on desktop.

@mrx23dot
Copy link
Author

mrx23dot commented Jun 7, 2022

It does work for simple url-s, but not for the mentioned one.

@mrx23dot
Copy link
Author

mrx23dot commented Jun 8, 2022

As I read it from source a link is marked as visited if it opens inside the browser, this might be the problem that it opens in another app.

viewModel.logVisitedHistory(tab.title, tab.url, tab.faviconHash, config.incognitoMode)

@mrx23dot
Copy link
Author

Some more valid links on android:

http://192.168.0.64/media/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG[TGx]/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG.mkv#Intent;package=com.mxtech.videoplayer.pro;end
intent://192.168.0.64/media/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG[TGx]/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG.mkv#Intent;scheme=http;package=com.mxtech.videoplayer.pro;end
android-app://com.mxtech.videoplayer.pro/http/192.168.0.64/media/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG[TGx]/The.Humans.2021.720p.AMZN.WEBRip.800MB.x264-GalaxyRG.mkv

@mrx23dot
Copy link
Author

As I understand the code, it only adds visited link if it's open in the browser itself,
it should be added on click so action can be finished outside the app.

@mrx23dot mrx23dot changed the title Visited state fails for complex url Visited link fails Aug 15, 2022
@mrx23dot
Copy link
Author

#172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant