Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Usage of pify breaks reference to provider #124

Closed
danfinlay opened this issue Oct 8, 2018 · 1 comment
Closed

Usage of pify breaks reference to provider #124

danfinlay opened this issue Oct 8, 2018 · 1 comment

Comments

@danfinlay
Copy link

danfinlay commented Oct 8, 2018

At MetaMask we've been blocked from rolling out our new provider, because it breaks Drizzle, and we don't want to break every Drizzle app.

As documented in MetaMask/metamask-extension#5459:

  • Drizzle pifies its provider, breaking the this reference.
    • Should make sure pify method receives correct context argument.
    • May also require patch in blocktracker-es5 2.3.2, which we don't own. (I'm not clear what this would be yet, will define later).
@OnlyOneJMJQ
Copy link
Contributor

Thanks for bringing this to our attention @danfinlay. Closing with merger of #131.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants