This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Overload eventemitter on method to handle data listeners #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this essentially bypasses the memoryleak warning for data event listeners by increasing the max listeners as needed
|
Eh. Just going to drop web3 soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially bypasses the memoryleak warning for data event listeners by increasing the max listeners as needed.
This fixes #267, but I'm not sure if this approach is even a sane one. A better implementation is fixing the issue at the core in web3.js (see #267 for more details).