You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
For clients that connect to the ganache server over HTTP with keepAlive ganache will not immediately close those connections when the server is shutdown, these connections wait until the keepAlive timeout is finished (10 seconds) or until the client sends another request.
these connections wait until the keepAlive timeout is finished (10 seconds) or until the client sends another request.
Are you saying that if the client sends another request, the keepAlive timeout will start over, and this will hole open the connection? @cds-amal and I are looking into another issue with Ganache not shutting down and are wondering if this is the cause.
As of #2667 Ganache will close the connection if another request is sent within the keepAlive window. What I'm am saying above is that we don't proactively close the keep alive connection (we wait for it to timeout or for another request to come in over the connection in order to close it).
For clients that connect to the ganache server over HTTP with keepAlive ganache will not immediately close those connections when the server is shutdown, these connections wait until the keepAlive timeout is finished (10 seconds) or until the client sends another request.
See uNetworking/uWebSockets.js#663 and #2667
This isn't just a uWS issue, node core also requires this pattern: nodejs/node#2642
The text was updated successfully, but these errors were encountered: