This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
We should stop using random values for the networkId
by default. Other dev tools don't do this, and it confuses everything.
#4334
Milestone
One such instance of an issue this has caused is in Brave. Brave wallet conflates
networkId
andchainId
when evaluating an chain's available tokens in it'sSwap
feature. AligningnetworkId
andchainId
makes it work.I propose that we change the default value for
networkId
to matchchainId
(which defaults to 1337). But it should match a user provided chainId as well. If the user wants a random id they can use the word"random"
. Open to discussion on the best path forward (this will be a breaking change).The text was updated successfully, but these errors were encountered: