Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

We should stop using random values for the networkId by default. Other dev tools don't do this, and it confuses everything. #4334

Open
davidmurdoch opened this issue Mar 30, 2023 · 0 comments
Milestone

Comments

@davidmurdoch
Copy link
Member

One such instance of an issue this has caused is in Brave. Brave wallet conflates networkId and chainId when evaluating an chain's available tokens in it's Swap feature. Aligning networkId and chainId makes it work.

I propose that we change the default value for networkId to match chainId (which defaults to 1337). But it should match a user provided chainId as well. If the user wants a random id they can use the word "random". Open to discussion on the best path forward (this will be a breaking change).

@davidmurdoch davidmurdoch added this to the 8.0.0 milestone Mar 30, 2023
@github-project-automation github-project-automation bot moved this to Inbox in Ganache Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

1 participant