Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

ci: remove node 12 from CI tests #4029

Merged
merged 4 commits into from
Dec 15, 2022
Merged

ci: remove node 12 from CI tests #4029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbb21a9
remove node 12 from CI tests
MicaiahReid Dec 14, 2022
3a7a257
update upgrade guide to drop node 14
MicaiahReid Dec 14, 2022
b170fe9
update node support statements
MicaiahReid Dec 14, 2022
d9865a8
Apply suggestions from code review
MicaiahReid Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [12.0.0, 12.x, 14.x, 16.x, 18.x]
node: [14.0.0, 14.x, 16.x, 18.x]
cds-amal marked this conversation as resolved.
Show resolved Hide resolved
os: [windows-2019, ubuntu-18.04, ubuntu-20.04, macos-11]
exclude:
# Node v18 does not run on ubuntu-18.04: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442
Expand Down
10 changes: 6 additions & 4 deletions UPGRADE-GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,13 @@ If you want to use the new default mode but still be able to get the reason for
a transaction failure, you need to resend your transaction with an `eth_call`.
This will return the revert reason in nearly all cases[^2].

#### Dropped support for Node v8 and v10
#### v7.0.0-7.6.0, Dropped support for Node v8 and v10

We no longer support Node v8 - v11. You'll need to update to Node v12.0.0 or
later. NOTE: Support for Node.js v12.x.x will be dropped shortly after the
Node.js Foundation stops supporting it in April 2022.
As of v7.0.0 we no longer support Node v8-v10. You'll need to update to Node v12.0.0 or later.

#### v7.7.0+, Dropped support for Node v12

We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023.
Copy link
Member

@cds-amal cds-amal Dec 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023.
We no longer support Node v12. You'll need to update to Node v14 or later. NOTE: Support for Node.js v14 will be dropped shortly after the Node.js Foundation stops supporting it in April 2023.

I think the extra zeros and .x.x are confusing in this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree; this is saying you currently need at least the lowest v14, which is 14.0.0. And that we will drop support for all node v14 versions, 14.x.x


#### DockerHub repo has been moved to trufflesuite/ganache

Expand Down