Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

docs: complete macOS node-gyp troubleshooting steps in CONTRIBUTING.md #4036

Merged
merged 7 commits into from
Jun 21, 2023
Merged

docs: complete macOS node-gyp troubleshooting steps in CONTRIBUTING.md #4036

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73757ea
Fill MacOS node-gyp troubleshooting guide
OnlyOneJMJQ Dec 15, 2022
ed04de6
Add final xcode-select reinstall measure
OnlyOneJMJQ Dec 15, 2022
fcdc210
Merge branch 'develop' into ngyp-macos-troubleshooting
davidmurdoch Dec 16, 2022
38f619c
Update CONTRIBUTING.md
davidmurdoch Jan 31, 2023
df907ff
Update python installation instructions
jeffsmale90 Jun 20, 2023
16a6b52
Update CONTRIBUTING.md
jeffsmale90 Jun 21, 2023
ac8af96
Merge branch 'develop' into ngyp-macos-troubleshooting
jeffsmale90 Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,14 @@ If installation fails due to a `node-gyp` issue you may need to perform some add

### on macOS

- I have no idea.
- Determine if you have Xcode command line tools installed
- example the console will tell you if they're already installed): `xcode-select --install`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the steps more prescriptive? i.e., tell the user what to do directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style (minus the missing "(") matches the other instructions. Would you like me to modify those too? They're short so it wouldn't take long.

- Determine if you have Python 2.7 installed
- example: `which python2.7`
- If you do not have Python 2.7 installed, you need to install it. We recommend `pyenv` for this so you can keep the default MacOS python installation untouched.
1. [Install `pyenv`](https://github.com/pyenv/pyenv#homebrew-in-macos)
2. [Setup your shell environment for `pyenv`](https://github.com/pyenv/pyenv#set-up-your-shell-environment-for-pyenv)
3. Install Python 2.x: `pyenv install 2.7.18`

## Clean install

Expand Down