Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Compatibility with newer Web3 versions #1690

Closed
filips123 opened this issue Jan 31, 2019 · 12 comments
Closed

Compatibility with newer Web3 versions #1690

filips123 opened this issue Jan 31, 2019 · 12 comments
Labels

Comments

@filips123
Copy link
Contributor

Truffle has many problems with Web3 since 1.0.0-beta.38.

There were many changes in this version including refactoring, porting to ES6 and implementing EthereumProvider. You can see a summary of all changes here. It looks like some of that changes are incompatible with Truffle, so it has many problems.

There was already fix for that (see #1667 and #1689), but it only locked Web3 to 1.0.0-beta.37 which had no problems.

This should only be a quick temporary solution because it now uses outdated Web3 version. There should be support for newer versions.

@levino
Copy link

levino commented Jan 31, 2019

It looks like some of that changes are incompatible with Truffle, so it has many problems.

This should be expected if one uses a software clearly marked as "beta", right? I honestly wonder what exactly the "many problems" are. I did not encounter any when using truffle. Maybe you can add some links to issues that are caused by using the old version of the web3 beta.37?

@filips123
Copy link
Contributor Author

Problems are not caused by the old version (beta.37), but with new (beta.38 and later). Some of them are #1667.

For now, there is nothing wrong with using that old version, but I opened that issue because Truffle would need to move to a new Web3 version (if not earlier when 1.0 becomes stable).

@gnidan
Copy link
Contributor

gnidan commented Jan 31, 2019

Thanks for opening this!

@gnidan
Copy link
Contributor

gnidan commented Jan 31, 2019

FWIW this is related web3/web3.js#2266

@filips123
Copy link
Contributor Author

@levino @gnidan Now this seems like a very important bug. Because of #2070, Truffle is unusable on Node.js 12.

@gnidan gnidan added the on hold label Jun 2, 2019
@gnidan
Copy link
Contributor

gnidan commented Jun 2, 2019

I'm labeling this on hold because the newer Web3.js versions include breaking changes, not only for Web3.js itself, but also for Truffle, since Truffle exposes Web3.js's external interface. These breaking changes will have to wait until Truffle v6.

We've identified a path forward; expect an announcement from Web3.js soon!

Thanks!

@filips123
Copy link
Contributor Author

When will Truffle v6 be released? I know it would be hard, but it is needed. Node.js 12 will become LTS in October, so if it won't be fixed until then, it could be a problem.

@filips123
Copy link
Contributor Author

filips123 commented Jul 23, 2019

@gnidan Web3 beta 37 is now released as stable 1.2.0. Can Truffle now be updated to use it? This would also fix #2140.

@eggplantzzz
Copy link
Contributor

Yes, I will get in a PR for Truffle to use 1.2.0 today.

@gnidan
Copy link
Contributor

gnidan commented Jul 26, 2019

It's released! Closing this, as Truffle v5.0.29 now comes with web3@latest

Thanks all!

@gnidan gnidan closed this as completed Jul 26, 2019
@levino
Copy link

levino commented Jul 26, 2019

How about linking the PR or commit?

@levino
Copy link

levino commented Jul 26, 2019

aaacccc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants