Add London support (minus access lists) to Truffle Contract #4214
Conversation
|
Hm, so it seems to work, sort of... but, like, it demands that maxFeePerGas and maxPriorityFeePerGas be given as hex strings. Uh, we can work around that if we have to, but in the meantime I'm going to go file an issue with web3... |
|
Oh, geez, it's worse than that! London transactions don't work at all because web3 adds a default |
|
Filed issues: |
|
How can I test this with the latest geth @haltman-at ? |
Is there a particular thing you're confused about, or are you looking for some sort of walkthrough? In the latter case Slack might be more appropriate here than GitHub comments... |
This PR adds support for London transactions, minus access lists, to Truffle Contract.
This PR is a draft because it needs to be tested. Unfortunately, it can't be tested with Ganache at the moment, because Ganache doesn't support London yet.
Obviously, prefer to wait until Ganache supports London before doing this, but London is coming soon and after discussing things with @gnidan we decided this is important enough not to wait. Access lists are less important, so for now we're still going to wait on that one.