Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Have new project match truffle init #194

Closed
emilyJLin95 opened this issue Aug 5, 2022 · 8 comments
Closed

Have new project match truffle init #194

emilyJLin95 opened this issue Aug 5, 2022 · 8 comments
Assignees

Comments

@emilyJLin95
Copy link

When I start a new Solidity project through the command palette, it should match the artifacts that are generated by truffle init

@acuarica
Copy link
Contributor

acuarica commented Aug 8, 2022

Hi @emilyJLin95, thanks for sending this. Currently the New Solidity Project command, followed by the Create basic project option, unboxes the vscode-starter-box. Not sure what the intended outcome should be.

@kevinbluer what should it do?

@kevinbluer
Copy link
Member

Likewise, thanks for opening @emilyJLin95! This has been on the radar to improve for a while. After briefly discussing with @acuarica earlier today, we landing on the following:

  • Create empty project (equivalent of truffle init)
  • Create sample project (current vscode-starter-box box with some enhancements)
  • Create project from Truffle Box (which will launch another dropdown with the full list of all boxes)

I'm also tempted to suggest we include the following, although would love input. There's definitely an argument to include these under Truffle boxes, although of course giving them some increased visibility would be pretty cool too.

  • Create example NFT project
  • Create example Token project
  • Create example DAO project

Including the current dropdown for reference...

Screen Shot 2022-08-09 at 3 43 45 PM

@acuarica
Copy link
Contributor

I like the idea of including "most used" or "most relevant" boxes as first choices for the user.

Linking #25 since they are both related to having a list of boxes.

@kevinbluer
Copy link
Member

Yeah I like the idea of having (default) sorting by most used / relevant. Perhaps along with a text based filter in the same way we have it in place to filter networks when deploying?

Screen Shot 2022-08-10 at 10 52 08 AM

Also thanks for linking #25, I'll go ahead and consolidate this detail under there shortly.

@kevinbluer
Copy link
Member

cc @xhulz on this given it also ties into #25 which you're about to start work on. Let's discuss if any questions 👌

@kevinbluer kevinbluer moved this from No Status to Todo in vscode-ext-v2.6-arbequina 🌳 Aug 24, 2022
@xhulz
Copy link
Contributor

xhulz commented Aug 24, 2022

Ok, thanks @kevinbluer!

@xhulz
Copy link
Contributor

xhulz commented Sep 12, 2022

Hey @kevinbluer and @acuarica

As suggested by you folks, i've moved the directory selection from the beginning of the flow to the end.

PR ref #226

Thank you :)

@xhulz
Copy link
Contributor

xhulz commented Sep 14, 2022

merged in PR #222

@xhulz xhulz closed this as completed Sep 14, 2022
Repository owner moved this from Code Review to Done in vscode-ext-v2.6-arbequina 🌳 Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

5 participants