-
Notifications
You must be signed in to change notification settings - Fork 24
Declare network
option in launch configuration
#267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
package.json
Outdated
}, | ||
{ | ||
"label": "Truffle - Debugger Launch using config network", | ||
"description": "Runs the Truffle debugger (truffle) and attaches to a TestRPC instance", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor thing but just wondering if we should call it a "Ganache" instance vs "TestRPC" (given the latter is super dated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevinbluer for catching this. I've changed it to Ganache. Before I used TestRPC because it was used in a similar snippet, so I changed both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also approving as other than that (optional) minor comment it's good to go from my side.
PR description
This PR declares the newly added
network
option #261 in the launch configuration.truffle-test-debug-1669291480307.mp4
Moreover, it includes a new configuration snippet that uses the
network
option instead ofproviderUrl
truffle-test-debug-1669292644960.mp4
Documentation
doc-change-required
label to this PR if documentation updates are required.