Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Declare network option in launch configuration #267

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Nov 23, 2022

PR description

This PR declares the newly added network option #261 in the launch configuration.

truffle-test-debug-1669291480307.mp4

Moreover, it includes a new configuration snippet that uses the network option instead of providerUrl

truffle-test-debug-1669292644960.mp4

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

@acuarica acuarica added enhancement New feature or request doc-change-required Issue indicates a change to documentation is required labels Nov 23, 2022
Copy link
Contributor

@xhulz xhulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated
},
{
"label": "Truffle - Debugger Launch using config network",
"description": "Runs the Truffle debugger (truffle) and attaches to a TestRPC instance",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor thing but just wondering if we should call it a "Ganache" instance vs "TestRPC" (given the latter is super dated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinbluer for catching this. I've changed it to Ganache. Before I used TestRPC because it was used in a similar snippet, so I changed both.

Copy link
Member

@kevinbluer kevinbluer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also approving as other than that (optional) minor comment it's good to go from my side.

@acuarica acuarica merged commit 7f11787 into develop Dec 1, 2022
@acuarica acuarica deleted the fix/network-launch-config branch December 1, 2022 22:19
@acuarica acuarica mentioned this pull request Dec 5, 2022
1 task
@alexandratran alexandratran removed the doc-change-required Issue indicates a change to documentation is required label Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants