Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom support for opening a terminal and running a specified command #56

Closed
dhirschfeld opened this issue Feb 9, 2024 · 1 comment · Fixed by #70
Closed

Add custom support for opening a terminal and running a specified command #56

dhirschfeld opened this issue Feb 9, 2024 · 1 comment · Fixed by #70

Comments

@dhirschfeld
Copy link

The first part is easy with the jupyterlab-commands type:

  type: jupyterlab-commands
  source:
    - label: Open Terminal
      id: 'terminal:open'
      args:
        name: Browsr

...but it appears that there is no way to use that to execute a command (e.g. launch a terminal app) for security reasons:
jupyterlab/jupyterlab#5916

initialCommand is still a constructor arg so jupyterlab_app_launcher could define a special terminal type and create the terminal and run the initial command via the typescript api.

@trungleduc
Copy link
Owner

Hi, thanks for the suggestion, i'm happy to review PR implementing this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants