Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Support current merged EIP-712 specification #825

Closed
leroldary opened this issue Jul 10, 2018 · 5 comments
Closed

Support current merged EIP-712 specification #825

leroldary opened this issue Jul 10, 2018 · 5 comments
Assignees

Comments

@leroldary
Copy link

ethereum/EIPs#712 is merged. When/How do you plan to update from your current implementation of
eth_signTypedData to the new one specified in EIP-712?

@vikmeup
Copy link
Contributor

vikmeup commented Jul 11, 2018

@hewigovens can you take a look to see what we need to finish?

@leroldary
Copy link
Author

Metamask will add a deprecation warning to the old implementation in the next release MetaMask/metamask-extension#4905 and in the next release thereafter replace it with the current new EIP712 specification MetaMask/metamask-extension#4803.

Would be great if you could update your implementation to remain compatible with metamask.

@hewigovens
Copy link
Contributor

Thanks for your information, we will work on this soon

@leroldary
Copy link
Author

Just noticed, trust wallet for android has an EIP-712 implementation. But it seems it's neither compatible with the new merged EIP-712 specification nor with the old one implemented in MetaMask (which will be replaced soon). Which version of the specification is currently implemented for the android version?

@hewigovens
Copy link
Contributor

@leroldary Thanks, we have a branch if you'd like to track the progress.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants