New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request.socket.address() returns an IPv6 address #31

Open

suryatech opened this issue May 25, 2015 · 1 comment

Contributor

suryatech commented May 25, 2015

These lines suggest that we expect IPv4 addresses.

However, newer releases of node (tested with v0.12.2 ) return an IPv6 address by default.

@cyli @Kami @wadey

What do you think the correct workaround/fix should be?

suryatech changed the title ~~request.socket.address() returns an IPv6 format address~~ request.socket.address() returns an IPv6 address

Contributor

cyli commented Aug 5, 2015

@suryatech Apologies, I'm not really sure, but I did find these:

Net module socket.localAddress is changed in node 0.12 nodejs/node-v0.x-archive#9290 (looks like they solved it with a regex)
http://stackoverflow.com/questions/24896386/request-connection-remoteaddress-now-prefixed-in-ffff-in-node-js/31514365#31514365. (suggestion to solve it with ipaddr.js)

Seems like zipkin only supports IPv4 for now (see thrift definition) so we'll have to convert somehow. :|

suryatech mentioned this issue

Trace.fromRequest in Trace.js fails when using Unix Socket instead of TCP/IP Network Socket #36

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment