Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Noice notification Player drains the battery #426

Closed
franciscot opened this issue Dec 4, 2020 · 3 comments
Closed

The Noice notification Player drains the battery #426

franciscot opened this issue Dec 4, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@franciscot
Copy link
Contributor

franciscot commented Dec 4, 2020

Describe the bug

Sometimes Noice drains my battery. I can see that Noice's player appears in the notification when I turn on or off a headset. Even if Noice is not being used or is closed.

To Reproduce

Steps to reproduce the behavior:

  1. Noice is "closed" or not using
  2. Plug or unplug headset.
  3. Noice opens notification player.
  4. Turn off my tablet. (sleep mode)
  5. Noice drains my battery while my tablet is on sleep mode.

Expected behavior

Noice doesn't run when you plug or unplug a headset.

Others

  • Device: Nexus 7 2013 wifi (flo)
  • Android Version: Lineage os 14.1 (Android version 7.1.2)

Example, Noice drained 30% of the battery in one night:
nexus 7

@franciscot franciscot added the bug Something isn't working label Dec 4, 2020
@ashutoshgngwr ashutoshgngwr self-assigned this Dec 4, 2020
@ashutoshgngwr
Copy link
Member

Hi @franciscot!

This is (was) the intended behavior. Noice expects an user to manually stop the player from the notification. Hence, the current behavior will pause the playback when you unplug the headset, but Noice won't release its resources unless you click the stop button from the notification. I can see why this should not be the intended behavior.

PS, in some other cases, e.g. when you start another media player, Noice is set to pause the playback. If user doesn't resume the playback within 1 minute (now I am setting it to 5 minutes), Noice completely shuts down releasing all its resources. I am extending the same behavior to this case.

@ashutoshgngwr
Copy link
Member

I have fixed this, but you'll have to wait for the next release. Until then, consider manually stopping Noice from the notification after unplugging headphones.

@franciscot
Copy link
Contributor Author

Thank you very much @ashutoshgngwr
Great Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants