Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in PyPI #238

Closed
ptim0626 opened this issue May 29, 2024 · 9 comments
Closed

Version in PyPI #238

ptim0626 opened this issue May 29, 2024 · 9 comments

Comments

@ptim0626
Copy link

Thanks for the package.

I have recently tried to pip-install xraylib from PyPI (https://pypi.org/project/xraylib), but it doesn't have versions that support Python 3.11 and 3.12. I can see that it supports Python 3.11 and 3.12 in conda-forge (https://anaconda.org/conda-forge/xraylib).

Does xraylib support installation from PyPI? Thank you

@tschoonj
Copy link
Owner

Hi Timothy, the xraylib wheels found on PyPI were not added by myself, but by the ESRF.

@srio can you help Tim out with this?

@ptim0626
Copy link
Author

ptim0626 commented Jul 3, 2024

Just to check if there is any update on this? Thank you.

@srio
Copy link

srio commented Jul 10, 2024

Hello, and sorry for the late answer. Yes, we created the pypi wheels at ESRF. I'm looking to create the 3.11 and 3.12 ones, so I ask for a bit more patience (a few days hopefully...).

@ptim0626
Copy link
Author

Hi @srio, much appreciate for the help!

@t20100
Copy link
Contributor

t20100 commented Jul 23, 2024

@tschoonj, would you be OK to add a github action workflow to release wheels on pypi?

As it is, wheels published by @srio on pypi are made with an ad-hoc CI set-up. Leveraging github actions and cibuildwheel would make wheels release using standard tools and the process to be opened.

I quickly made one for xraylib by adapting release workflow I recently set-up for other projects (e.g., https://github.com/silx-kit/silx/blob/main/.github/workflows/release.yml):

https://github.com/t20100/xraylib/blob/release-ci/.github/workflows/release.yml

It is triggered when publishing a release on github (but could also be triggered on tags), and automatically publish to pypi (the required configuration of github and pypi is simple).
Here is a run with current tip of the project:
https://github.com/t20100/xraylib/actions/runs/10060125621

If you are up for it, I can also help with the maintenance of the workflow (I already do so with @srio for our internal CI set-up).

@tschoonj
Copy link
Owner

I am not necessarily against publishing wheels through CI to PyPI, but the build backend I am using, mesonpep517, is not seeing further development, and lacks support for Windows.

I think that the backend needs to switch to meson-python instead, which is part of the meson project, and is actively developed.

Would you be willing to take a look at this?

@t20100
Copy link
Contributor

t20100 commented Jul 25, 2024

I unfortunately have no experience with meson, but some of my colleagues do, I'll check with them.
If we can propose something, that will not be before this autumn..

@tschoonj
Copy link
Owner

I will try and do it myself then. I expect the changes will be limited to pyproject.toml

@tschoonj
Copy link
Owner

I just released version 4.1.5, and wheels were published to PyPI for Python version 3.8 to 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants