Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with numpy v2 #240

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix build with numpy v2 #240

merged 2 commits into from
Jul 23, 2024

Conversation

t20100
Copy link
Contributor

@t20100 t20100 commented Jul 10, 2024

This PR proposes 2 changes:

closes #239

@tschoonj tschoonj closed this Jul 10, 2024
@tschoonj tschoonj reopened this Jul 10, 2024
@tschoonj
Copy link
Owner

Thanks for opening the PR, I will take a look at this soon

@t20100
Copy link
Contributor Author

t20100 commented Jul 11, 2024

CI failure on macos may be related to the change of macos-latest which is now macos-14 which runs on arm64.

@vespos vespos mentioned this pull request Jul 20, 2024
Merged
@tschoonj tschoonj force-pushed the cython branch 6 times, most recently from b9014d5 to e2ca391 Compare July 21, 2024 09:49
@tschoonj
Copy link
Owner

@t20100 I think this is ready for a merge now?

I have deployed your patch to Conda-forge already, so conda users will be able to use numpy 2 already.

@t20100
Copy link
Contributor Author

t20100 commented Jul 22, 2024

I think this is ready for a merge now?

It's OK for me!

Thanks for already having deployed the fix on conda!

@tschoonj tschoonj merged commit 7ee1206 into tschoonj:master Jul 23, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to build with numpy v2
2 participants
@t20100 @tschoonj