Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.6 reports incorrect version #1339

Closed
maciejwalkowiak opened this issue Mar 29, 2024 · 4 comments
Closed

1.7.6 reports incorrect version #1339

maciejwalkowiak opened this issue Mar 29, 2024 · 4 comments
Labels

Comments

@maciejwalkowiak
Copy link

Describe the bug

ttyd -v reports version 0.0.0-unknown making it impossible to use with https://github.com/charmbracelet/vhs, as VHS checks the ttyd version number before it runs.

To Reproduce

$ brew install ttyd
$ ttyd -v
ttyd version 0.0.0-unknown

Environment:

  • OS: macOS 14.2.1
@tsl0922
Copy link
Owner

tsl0922 commented Mar 29, 2024

It should work if you install it with brew install ttyd --HEAD.

The version info is fetched from git tag in 1.7.6 release, homebrew uses source archive which is not a git repo, so no version info will be detected..

@maciejwalkowiak
Copy link
Author

Thanks for quick reply. Confirming, installing with --HEAD solves the problem.

@tsl0922
Copy link
Owner

tsl0922 commented Mar 30, 2024

Sorry for the confusion, I've released 1.7.7 to revert the static version in source archive.

The release action now checks the version bump, it will fail if I forget to bump version in CMakeLists.txt.

@tsl0922 tsl0922 closed this as completed Mar 30, 2024
@maciejwalkowiak
Copy link
Author

Fantastic! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants