Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcbox is is inconsistent with chatterbox/h2_client #18

Open
carolcarolus opened this issue Sep 9, 2019 · 1 comment
Open

grpcbox is is inconsistent with chatterbox/h2_client #18

carolcarolus opened this issue Sep 9, 2019 · 1 comment

Comments

@carolcarolus
Copy link

Hi,

I noticed that grpcbox uses functions that do not exist. For example, grpcbox_subchannel.erl(line 96) uses:
case h2_client:start_link(Transport, Host, Port, options(Transport, SSLOptions), #{stream_callback_mod => grpcbox_client_stream}) of
There is no five argument function in chatterbox application.

Unfortunately it is required to create a new stream.

I am using the latest versions of grpcbox and chatterbox.

@tsloughter
Copy link
Owner

@carolcarolus I have a fork of chatterbox that grpcbox is using. I have not merged it into chatterbox because, even though I maintain chatterbox now, I have not had anyone to help with reviews. I hope that changes now and we will see updates to chatterbox soon and remove the need for my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants