Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-timeout header not matching the spec #85

Closed
tonnyk00 opened this issue Sep 6, 2022 · 1 comment · Fixed by #89
Closed

grpc-timeout header not matching the spec #85

tonnyk00 opened this issue Sep 6, 2022 · 1 comment · Fixed by #89

Comments

@tonnyk00
Copy link

tonnyk00 commented Sep 6, 2022

Hi,

When testing with a deadline in context, the timeout value is converted to nanosecond in grpc-timeout header.
But there is no check of the TimeoutValue range, which could result in the server rejecting the msg with protocol error.

The grpc spec specified that the TimeoutValue can contain at most 8 digits:

TimeoutValue → {positive integer as ASCII string of at most 8 digits}

Best regards,
Tonny

@tsloughter
Copy link
Owner

Ah thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants