Embeded gleam into k6 extension #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops, meant to put the "take more time to review" comment on this one :) Does this PR replace the others? |
It based on #1, so we can that PR first and continue working on this. :) |
|
k, done (with the merge of #1) |
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
* Get rid of `k6/build.gleam` and `k6/internal.gleam`. * Remove runner_js scaffolding out of `k6/new.gleam`. * Runner js is now removed. Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
|
The PR is now ready to review. Here is the summarize:
|
|
@wingyplus this got merged grafana/k6#3456 -- I think it gives us more options? |
|
@tsloughter yes, the esbuild is not necessary now. 🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a k6 extension to transpile gleam source into javascript and bundling it with
k6pack, a wrapper api aroundesbuild.How to build
The
k6binary will present underxk6-gleam. You can use that binary to run gleam source under gleam project.