Linting on files with syntax errors

[ostreifel]

I noticed that if even one line of the file has a syntax error the whole file will be ommitted from linting checks.

[dougwilson]

I believe this is the same behavior as other linters like eslint for javascript. If the parser is unable to parse the file, I'm not sure how it would be able to lint it. Any thoughts on a possible solution?

[ostreifel]

Currently the visitor checks for errors but I think it should just check if the fragment is not null.

namespace TSQLLint.Tests.UnitTests.Parser
{
    using System.IO;
    using NUnit.Framework;
    using TSQLLint.Lib.Parser;

    [TestFixture]
    public class FragmentBuilderTests
    {
        [Test]
        public void TestError()
        {
            var file = new StringReader(@"
                CREATE PROCEDURE proc1
                    ,@param1 NVARCHAR(someConst) = null;
                AS
                return 0;
");
            var builder = new FragmentBuilder();
            var fragment = builder.GetFragment(file, out var errors);
            Assert.AreNotEqual(0, errors.Count);
            Assert.NotNull(fragment);
        }
    }
}

[dougwilson]

Oh, I see, you're saying it would br some kind of change to the C# lib, not the extension, haha. I was super confused. So the repo and code for the lib is https://github.com/tsqllint/tsqllint if you want to open an issue (but a PR is even more ideal) 👍

[ostreifel]

Ok thanks, will do