Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] align/sync library functionality with modern alternatives like GOT #457

Open
OleksandrKucherenko opened this issue Feb 19, 2024 · 4 comments

Comments

@OleksandrKucherenko
Copy link

ref:

@klippx
Copy link
Collaborator

klippx commented Feb 19, 2024

What is the benefit of aligning it with competitors? I think different libraries should offer different flavours. Axios, Got, Ky they all do same / similar things and have different opinions on how to organise and think about an HTTP client. The risk otherwise is that we lose our direction and become a washed out copy of everything else.

And if I understood you correct then there would be massive breaking API changes for no reason other than trying to be modern.

I think you need to be more specific what exactly is the idea you want to pursue.

@OleksandrKucherenko
Copy link
Author

all those new libs are usually introduce new features, like: AbortSignals or nice "syntax sugar" patterns that makes code simpler. Author of the library should decide on their own what patterns are useful and what are harmful, that is why I call it SYNC with other libraries.

@OleksandrKucherenko
Copy link
Author

Please take a look on GOT documentation, its a nice comparison table and list of features: https://github.com/sindresorhus/got

copy/paste from their readme

Main API

Timeouts and retries

Advanced creation

Cache, Proxy and UNIX sockets

Integration


Migration guides

@klippx
Copy link
Collaborator

klippx commented Sep 11, 2024

Related, but small, update: #557 will add support for abort signals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants