Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display member vote comments [RFC] #245

Open
helmturner opened this issue May 8, 2024 · 0 comments
Open

feat: display member vote comments [RFC] #245

helmturner opened this issue May 8, 2024 · 0 comments

Comments

@helmturner
Copy link
Member

helmturner commented May 8, 2024

EDIT: On further thought, I want to change the scope of this issue to "vote comment UI". I think it still makes sense to accept comments as a form of feedback even if we don't publish them. The rest of this issue is still relevant to that narrower scope.

This was (somewhat haphazardly) thrown into the API spec, but let's put a pin in it. In light of the hidden complexity here I think it's best to mark this as a "nice to have" and swing back around to it. Further discovery uncovered the following implications to consider:

  1. Listing/paginating votes

With just a numeric value, votes are simple to aggregate and display; they can be totaled either server-side or client-side and displayed in aggregate with a simple numeric affordance. Adding comments necessitates an entirely new UI for listing and displaying those comments—each of which would require it's own affordance.

  1. Deciding what to display (and how to model it in the API)

Are comments displayed on their own, or alongside individual vote values? Do comments have a unique endpoint, or are they coupled with the proposals endpoints? How do individual vote values factor in?

  1. Anonymity

Displaying individual user votes has implications for the system as a whole, possibly influencing vote outcomes. This would need to be discussed at a higher level.

@helmturner helmturner changed the title feat: vote comments [RFC] feat: display member vote comments [RFC] May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant