Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"config.json has changed: reload!" popup occurs often #106

Closed
dostuffthatmatters opened this issue Aug 25, 2022 · 2 comments
Closed

"config.json has changed: reload!" popup occurs often #106

dostuffthatmatters opened this issue Aug 25, 2022 · 2 comments
Assignees
Labels
scope:ui status:implemented has been implemented in some dev branch

Comments

@dostuffthatmatters
Copy link
Member

Sometimes, when changing config parameters in the UI, the config.json gets read before the update but is dealt with in the UI after the state has changed. This results in the "config.json has changed" popup being triggering by regular UI use.

The UI is fully usable and this does not happen that often, but can be a bit annoying.

A possible fix could be to ignore config.json reads until ~ 5 seconds after a change of config parameters in the UI.

@dostuffthatmatters dostuffthatmatters added the backlog not included in a planned update yet label Aug 25, 2022
@dostuffthatmatters
Copy link
Member Author

Another bug here is that the popup appears multiple times.

@dostuffthatmatters dostuffthatmatters added backlog not included in a planned update yet and removed status:planned is assigned to a specific milestone labels Feb 7, 2023
@dostuffthatmatters dostuffthatmatters added status:in-progress is being work on in some dev branch and removed backlog not included in a planned update yet labels Oct 30, 2023
@dostuffthatmatters dostuffthatmatters added status:implemented has been implemented in some dev branch and removed status:in-progress is being work on in some dev branch labels Oct 30, 2023
@dostuffthatmatters
Copy link
Member Author

The easiest way to fix this is to actually not load the config periodically anymore but only on window load. The only item that is refreshed periodically is measurement_decision.cli_decision_result. For all other settings, if someone uses both CLI and UI to update the config, then they must know what they are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ui status:implemented has been implemented in some dev branch
Projects
None yet
Development

No branches or pull requests

1 participant