Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Pydantic #174

Closed
dostuffthatmatters opened this issue Jul 8, 2023 · 2 comments
Closed

Migrate to Pydantic #174

dostuffthatmatters opened this issue Jul 8, 2023 · 2 comments
Assignees
@dostuffthatmatters
Labels
status:implemented has been implemented in some dev branch
Milestone
4.1.0 - Upload & ...

Comments

@dostuffthatmatters
Copy link
Member

The current way of validating the different JSON objects is very bad (combination of Ceberus and Pydantic). Fully moving to Pydantic will make future changes significantly easier.
@dostuffthatmatters dostuffthatmatters added type:refactoring status:planned is assigned to a specific milestone labels Jul 8, 2023
@dostuffthatmatters dostuffthatmatters self-assigned this Jul 8, 2023
@dostuffthatmatters dostuffthatmatters added status:in-progress is being work on in some dev branch and removed status:planned is assigned to a specific milestone labels Jul 8, 2023
@dostuffthatmatters
Copy link
Member Author

@patrickjaigner this does not change anything about the validation logic. It just makes the codebase tremendously simpler.

@patrickjaigner
Copy link
Contributor

@dostuffthatmatters I agree, no concerns.

@dostuffthatmatters dostuffthatmatters added status:implemented has been implemented in some dev branch and removed status:in-progress is being work on in some dev branch labels Oct 4, 2023
@dostuffthatmatters dostuffthatmatters mentioned this issue Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dostuffthatmatters dostuffthatmatters

Labels
status:implemented has been implemented in some dev branch
Projects
None yet
Milestone
4.1.0 - Upload & Other Improvements
Development

No branches or pull requests
2 participants
@dostuffthatmatters @patrickjaigner