Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload should only run, when measurements are not running #177

Closed
dostuffthatmatters opened this issue Jul 19, 2023 · 0 comments
Closed
Assignees
Labels
scope:upload status:implemented has been implemented in some dev branch

Comments

@dostuffthatmatters
Copy link
Member

dostuffthatmatters commented Jul 19, 2023

Reason: computer should not get too hot and slow.

Solution: Binding the should_upload_abort callback to the measurements_should_be_running state and don't even start a new upload when this is the case. This way we don't have to configure any times for the upload to run.

Config addition: Add a config parameter allow_uploads_during_measurements and explain this button in the UI. Set this to false in the migration.

@dostuffthatmatters dostuffthatmatters added the status:planned is assigned to a specific milestone label Jul 19, 2023
@dostuffthatmatters dostuffthatmatters self-assigned this Jul 19, 2023
@dostuffthatmatters dostuffthatmatters added scope:upload status:implemented has been implemented in some dev branch and removed status:planned is assigned to a specific milestone labels Oct 25, 2023
@dostuffthatmatters dostuffthatmatters mentioned this issue Oct 25, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:upload status:implemented has been implemented in some dev branch
Projects
None yet
Development

No branches or pull requests

1 participant