Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to replace background/header image #3

Closed
ilhanDKSR opened this issue Jun 9, 2023 · 9 comments
Closed

Option to replace background/header image #3

ilhanDKSR opened this issue Jun 9, 2023 · 9 comments
Assignees
Labels
effort: 1 type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Comments

@ilhanDKSR
Copy link

Feature description

Is there an easy way to replace the background/header image? And, if not, it would be great to have one.

Suggested solution

No response

Code snippets

No response

@ilhanDKSR ilhanDKSR added state: triage New issue that requires triage. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Jun 9, 2023
@BWibo
Copy link
Member

BWibo commented Jun 11, 2023

Yes, this needs to be resolved in the Docker image. This and some other styling related issues are already being worked on:

@BWibo BWibo added priority: soon state: pending Pending requirements, dependencies, or data. state: approved Approved to proceed. and removed state: triage New issue that requires triage. state: pending Pending requirements, dependencies, or data. labels Jun 11, 2023
@BWibo
Copy link
Member

BWibo commented Jun 12, 2023

@ilhanDKSR If you have other style related issues/suggestions, please contribute that to tum-gis/ckan-docker#23. We're happy for any input to that.

@MarijaKnezevic
Copy link
Contributor

The ckan-docker v 1.1.0 includes improvements which are mentioned in issue tum-gis/ckan-docker#23

@BWibo
Copy link
Member

BWibo commented Jul 3, 2023

Re-opening, as this is not fully resolved. The new docker image supports this now, but the options are not jet documented and mapped to the Helm chart.

@BWibo BWibo reopened this Jul 3, 2023
@ilhanDKSR
Copy link
Author

Hi, and thanks for the quick feedback. From what I can tell, the current solution is to do this before deployment but after building the image, right? Is there also an option to do this on a running instance?

@MarijaKnezevic
Copy link
Contributor

@ilhanDKSR You can do this either before deployment or in a running instance.
The latest image includes the option to change this in the running instance. See the cangelog to see which options are added.
In the running instance, you can change this only if you are Admin. You should select "Systemadmin settings" -->"Config" Button, as shown in the following image. There you can add/remove/change text and images.
image

@BWibo
Copy link
Member

BWibo commented Jul 4, 2023

@MarijaKnezevic Thx, for the quick replay. What's the status on the documentation of these new options?

With the stack you can currently do it both ways with a little tewak. Using ckan.extraEnv the required variables can be passed using the helm chart already, to supply the options at deploy time. However, I am going to expose them in the ckan values as soon as there is a proper documentation, see #8.

@MarijaKnezevic
Copy link
Contributor

MarijaKnezevic commented Jul 4, 2023

@BWibo for status with documentation please see the following issue:

@BWibo BWibo closed this as completed Jul 6, 2023
@BWibo
Copy link
Member

BWibo commented Jul 6, 2023

Resolved in v1.1.1

@BWibo BWibo added effort: 1 and removed priority: soon state: pending Pending requirements, dependencies, or data. state: approved Approved to proceed. labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 1 type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

No branches or pull requests

3 participants