Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve one test: parallel + settle:false #42

Open
tunnckoCore opened this issue May 1, 2017 · 1 comment
Open

Improve one test: parallel + settle:false #42

tunnckoCore opened this issue May 1, 2017 · 1 comment

Comments

@tunnckoCore
Copy link
Owner

It's not correct. It no matter that .catch is called. In parallel mode, currently, "fail fast" more means "call .catch when fail-fast, otherwise don't call .catch, but always then()", instead of "stop executing the other tests after the first error"
@tunnckoCore
Copy link
Owner Author

https://github.com/tunnckoCore/each-promise/blob/master/test/parallel.js#L55-L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tunnckoCore