Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 2.4.1 causes compile errors. #327

Closed
BurtHarris opened this issue Jun 29, 2017 · 1 comment
Closed

TypeScript 2.4.1 causes compile errors. #327

BurtHarris opened this issue Jun 29, 2017 · 1 comment
Assignees
@BurtHarris
Labels
fixed
Milestone
0.5.0-alpha.1

Comments

@BurtHarris
Copy link
Collaborator

There is some enhanced type checking introduced in TypeScript 2.4, generating errors in the current source code. For example:

src/Recognizer.ts(73,4): error TS2322: Type 'Readonly<Map<string, number>>' is not assignable to type 'ReadonlyMap<string, number> | undefined'.

Also the stub decorators like @NotNull aren't declared properly to be used as parameter decorators.
@BurtHarris BurtHarris self-assigned this Jun 29, 2017
@BurtHarris
Copy link
Collaborator Author

BurtHarris commented Jun 29, 2017 •
edited
Loading

See issue microsoft/TypeScript#16840

@BurtHarris BurtHarris mentioned this issue Jun 30, 2017
Closed
@sharwell sharwell mentioned this issue Jul 1, 2017
Merged
@sharwell sharwell added this to the 0.5.0-alpha.1 milestone Nov 30, 2018
@sharwell sharwell added the fixed label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BurtHarris BurtHarris

Labels
fixed
Projects
None yet
Milestone
0.5.0-alpha.1
Development

No branches or pull requests
2 participants
@sharwell @BurtHarris