Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #1

Open
mappum opened this issue Nov 15, 2019 · 0 comments
Open

Error handling #1

mappum opened this issue Nov 15, 2019 · 0 comments

Comments

@mappum
Copy link
Contributor

mappum commented Nov 15, 2019

Errors aren't currently handled well - we should probably use error-chain to make the type conversion cleaner, and pass write errors from the write thread to the consumer through a separate error channel. We should also ensure the connection gets closed/invalidated once an error happens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mappum